Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activity retry timer #5174

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix activity retry timer #5174

merged 1 commit into from
Mar 28, 2023

Conversation

Shaddoll
Copy link
Member

What changed?
Add missing PartitionConfig field to AddActivityTaskRequest

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01872952-72cf-4b52-a468-334572d6bafd

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 152 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-0.004%) to 57.067%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/membership/hashring.go 2 83.54%
common/persistence/historyManager.go 2 66.67%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
common/util.go 2 52.68%
service/history/handler.go 2 47.15%
service/history/task/transfer_standby_task_executor.go 2 86.93%
common/persistence/statsComputer.go 3 96.07%
common/persistence/serialization/parser.go 4 63.91%
Totals Coverage Status
Change from base Build 01871487-7dc6-415a-b198-8d551ccc3790: -0.004%
Covered Lines: 85549
Relevant Lines: 149911
💛 - Coveralls

@Shaddoll Shaddoll merged commit 3cd35e7 into cadence-workflow:feature/zonal-partitioning Mar 28, 2023
@Shaddoll Shaddoll deleted the fix-retry-timer branch March 28, 2023 19:34
Shaddoll added a commit to Shaddoll/cadence that referenced this pull request May 8, 2023
@Shaddoll
Fix activity retry timer (cadence-workflow#5174)
2f73fd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaddoll @coveralls @davidporter-id-au